This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Bus-mapping for opcode calldatacopy#393
Merged
ChihChengLiang merged 32 commits intoMar 21, 2022
Merged
Conversation
2. Remove gas calculation and set in `calldatacopy` bus-mapping. 3. Revert `test_ok_internal` since not want to set internal call.
github-actions
Bot
added
crate-bus-mapping
github-actions
Bot
added
the
crate-zkevm-circuits
Collaborator
|
I suggest that we should merge this PR even though |
29 tasks
ed255
approved these changes
Mar 18, 2022
Contributor
ed255
left a comment
ed255
left a comment
There was a problem hiding this comment.
Great work! Thanks for working on this :)
I've added a few comments with minor suggestions, but overall everything looks good!
Contributor
|
Let's wait for a second review and afterwards we can merge this! |
ChihChengLiang
approved these changes
Mar 21, 2022
Collaborator
ChihChengLiang
left a comment
ChihChengLiang
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the PR!
19 tasks
zemse
pushed a commit
to zemse/zkevm-circuits
that referenced
this pull request
Mar 22, 2023
…th is zero (privacy-ethereum#393) * Truncate memory offset of Word to Uint64 for Call opcodes when memory length is zero. * Truncate memory offset for `CALLDATACOPY`. * Truncate memory offset for `CODECOPY`. * Truncate memory offset for `EXTCODECOPY`. * Truncate memory offset for `RETURNDATACOPY`. * Truncate memory offset for `RETURN` and `REVERT`. * Truncate memory offset for `SHA3` (`KECCAK256`). * Truncate memory offset for `CREATE` (and `CREATE2`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #309
Summary
ExecStateto bus-mappingExecStepto support Virtual step BeginTx, EndTx and CopyToMemory.new_steptoCircuitInputStateReffor multi-step support.CallDataCopybus-mapping only for root call. Will send another PR for internal call of CallDataCopy bus-mapping when PR ImplementationExecutionState::CALL#278 is merged.